[App size reduction] Remove domain-credit asset and related code
#15754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamgabrielma
added
type: task
Collaborator
Generated by 🚫 Danger |
Collaborator
|
|
Contributor
|
Hi @iamgabrielma - could you please remove all the domain folder and tests? I don't think keeping them around is useful. |
Contributor
Author
No problem! I've removed the domain folder and tests from the woo layer, but there's still dead code in Yosemite and Networking. This can be handled separately, as this PR is already close to 3k lines 👍 |
itsmeichigo
approved these changes
Jun 17, 2025
iamgabrielma
deleted the
task/part-of-WOOMOB-534-remove-domain-credit-ref
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the usage of the unused
domain-creditimage as part of reducing the app size on WOOMOB-534. After checking with Kiwi folks it seems we no longer have an entry point for the domain purchase feature as a whole ( #15680 ), so I took the opportunity to clean up the related code as well.I've only removed the code directly coupled with the feature, happy to remove the rest in this same PR (there's still files remaining under the
/domainsfolder as well as 2 test suites that we might not need to run anymore).Testing information
Domains rowunder Menu tab > Settings, on a WPCom test store without a custom domain, and no other entry points or access to the deleted files since theDomainSettingsCoordinatoris out of the settings controller, but let me know if I missed something.